Fix LTS dates #1167
Open
Fix LTS dates #1167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-website ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for issue 1154
It seems like the central issue is the format of the dates does not include timezones; adding the timezone data fixed these issues for me. The first object has the specific time from the 6.5.0 release gathered from 'pnpm info ember-source time', while the second is unchanged and we see the previous day bug.
I updated all the dates to include times, mostly using noon UTC as default, and occasionally using more specific time when the promotion day information corresponded properly with info outputted from 'pnpm infor ember-source-time' (like the above example); a screenshot of the site running locally with dates fixes:
to compare against the waybackmachine:
The instuctions for adding LTS mentions updating the page by adding markdown to the data/project/ember folder, which should now be added with timezone data. Currently it does not request or include timezone.
I have added timezone dates to these so that users will include them in the future.